-
Notifications
You must be signed in to change notification settings - Fork 96
Update Readme to add uid element and container_links object (#445, #468) #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
phillxnet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hooverdan96 This is great, just a couple of line-feed additions re my interpretation and to avoid massive lines. I've commented that my interpretation is that a sentence is a semantic packet in-and-of itself. We would go further in that a clause would also be a sub-packet that could, on a line of it's own, be more easily machine tracked difference managed.
So requested changes, and lets get this out there-after as it's definitely an improvement.
Re semantic reference use I would look to the website repo source under content.
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
|
I am also working on putting the semantic formatting into the website documentation. You should see a proposal over there shortly. Update: PR #554 in the rockstor-doc repo has been created. |
phillxnet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hooverdan96 Nice, a definite improvement and good to get these elements finally documented up-front.
|
@Hooverdan96 Thanks for seeing to these changes, and for taking care with that uid description. We can hopefully get this accompanied by a parallel gid option soon. But of course we are then dependant on a set version of Rockstor running: but bit-by-bit. |
Update Readme to add the
uidelement andcontainer_linksstructureReformat using semantic line breaks and clarity
Fixes #445 and #468.
I know, usually one topic, one PR, however in this case I felt it expedient to combine the two, as we have recently added more scenarios with multiple containers and non-root run requirements, respectively. Since this functionally doesn't change anything I would consider that safe.
Please review and suggest changes/additions/deletions.