Skip to content

Conversation

@Hooverdan96
Copy link
Member

@Hooverdan96 Hooverdan96 commented Sep 11, 2025

Update Readme to add the uid element and container_links structure
Reformat using semantic line breaks and clarity

Fixes #445 and #468.

I know, usually one topic, one PR, however in this case I felt it expedient to combine the two, as we have recently added more scenarios with multiple containers and non-root run requirements, respectively. Since this functionally doesn't change anything I would consider that safe.

Please review and suggest changes/additions/deletions.

@Hooverdan96 Hooverdan96 added the needs review Test install, function, on / off behaviour, all links / info. label Sep 11, 2025
@Hooverdan96 Hooverdan96 linked an issue Sep 11, 2025 that may be closed by this pull request
Copy link
Member

@phillxnet phillxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hooverdan96 This is great, just a couple of line-feed additions re my interpretation and to avoid massive lines. I've commented that my interpretation is that a sentence is a semantic packet in-and-of itself. We would go further in that a clause would also be a sub-packet that could, on a line of it's own, be more easily machine tracked difference managed.

So requested changes, and lets get this out there-after as it's definitely an improvement.

Re semantic reference use I would look to the website repo source under content.

Hooverdan96 and others added 3 commits September 12, 2025 07:10
Co-authored-by: Philip Guyton <[email protected]>
Co-authored-by: Philip Guyton <[email protected]>
@Hooverdan96
Copy link
Member Author

Hooverdan96 commented Sep 12, 2025

I am also working on putting the semantic formatting into the website documentation. You should see a proposal over there shortly.

Update: PR #554 in the rockstor-doc repo has been created.

Copy link
Member

@phillxnet phillxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hooverdan96 Nice, a definite improvement and good to get these elements finally documented up-front.

@phillxnet
Copy link
Member

@Hooverdan96 Thanks for seeing to these changes, and for taking care with that uid description. We can hopefully get this accompanied by a parallel gid option soon. But of course we are then dependant on a set version of Rockstor running: but bit-by-bit.

@phillxnet phillxnet merged commit fc291df into rockstor:master Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Test install, function, on / off behaviour, all links / info.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "container_links" object to Readme Add "uid" element to README.md

2 participants