fix: make bracketed paste work like osc 52 paste#251
Open
timeopochin wants to merge 2 commits intorockorager:mainfrom
Open
fix: make bracketed paste work like osc 52 paste#251timeopochin wants to merge 2 commits intorockorager:mainfrom
timeopochin wants to merge 2 commits intorockorager:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85
Some notes:
paste_allocatoris unwrapped without any checks. After some testing, when it isnulland cannot be unwrapped the zig compiler complains. So I took the liberty to add checks on the OSC 52 paste as well.paste, but none of them handle that possibility leading to memory leaks. I will open another issue about this.error.EscapeSequenceTooLongbut it might be better to implement a dynamic buffer in the case it ever exceeds the fixed size.