Open
Conversation
* vxfw(Border): add BorderLabels to Border widget * - changed enum names to snake_case. - used Grapheme Iterator instead of old range based loop. - used `ctx.stringWidth()` instead of `text.len`. - added empty label guard. * modified loop to use stringWidth instead of i range * - Added trailing comma at the end of BorderLabel alignment enum definition. - Changed from `.width=1` to `.width=width` * - Added @intcast for width * fix zig fmt errors
This also fixes the vt example. Fixes: 58bc3fd ("deps: update zg")
Unicode is not actually used by Screen anyway,
and Vaxis.init cannot return with Vaxis.screen.unicode assigned
as the pointer to Vaxis.unicode could be dangling.
The initial Vaxis without .screen.unicode
makes {Window,widgets.View}.gwidth a footgun.
This prevents reporting kitty mouse leave events as spurious mouse clicks.
use an eventfd so than winsize event is sent from input thread
rockorager
reviewed
Sep 19, 2025
| else => { | ||
| if (!builtin.is_test) { | ||
| if (self.winch_eventfd < 0) { | ||
| self.winch_eventfd = try std.posix.eventfd(0, 0); |
Owner
There was a problem hiding this comment.
eventfd isn't available on macOS or the BSDs. This would need to move a .linux block
Owner
|
What is the deadlock you are getting? I don't think this is the correct approach given that it provides a very specific path for Linux only. But I want to understand what the actual problem is better before reviewing much more. |
Author
Contributor
|
I just got this trace when resizing the window rapidly on macOS 26.0.1 (M1 MacBook Pro): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use an eventfd so than winsize event is sent from input thread
fixes #218