Tabithan Ho FTBC6#61
Open
tabbiho wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
4 hours
Please fill in one error and/or error message you received while working on this assignment.
Encountered some errors when trying to clearTimeout for purpose of extending the delay before a function is run and stopping the overall game timer when the game is won. However, learned that a global variable to hold the setTimeout function is required for use in another function.
What part of the assignment did you spend the most time on?
Figuring out how some of page's elements appear and disappear as the player progresses in the game, and deciding which are deliberate triggers and which are timed.
Comfort Level (1-5):
5
Completeness Level (1-5):
5
What did you think of this deliverable?
It looks and behave like an actual mini-game. There were a lot of "on hindsight" logic actually required, like on reset: the timer needs to be stopped and reset, board array needs to be cleared before adding a new set, having to clear the winning message so it does not remain up during next game... which were all picked up upon testing different user decision permutations.
Is there anything in this code that you feel pleased about?
Pleased of the completion of all the sections and figuring out some minor bugs that were fixed, even though there was only a very slim chance it might surface.