Ryan Ler Fundamentals 21#362
Open
ryanlerler wants to merge 3 commits into
Open
Conversation
ryanlerler
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
around 8 hours???
Please fill in one error and/or error message you received while working on this assignment.
invalid characters (if using Chinese input method)
What part of the assignment did you spend the most time on?
Part 1 - to get the correct emoji for user and PC separately and to refactor the codes;
Part 2 - tried to incorporate as many features as possible while making sure the output is appropriate
And as I didn't fork and git clone the project from RA Github initially (not instructed) and set up github username wrongly in the terminal earlier, spent lots of time trying to git push successfully
Comfort Level (1-5):
3
Completeness Level (1-5):
5 (base)
2 (more comfortable)
What did you think of this deliverable?
Interesting at the beginning of part 1 but then get complicated with many features and versions later
Is there anything in this code that you feel pleased about?
Incorporated a number of features (username, win/ loss record, formatting, reverse mode) in a single program
What's one aspect of your code you would like specific, elaborate feedback on?
Overall comments on the codes.
Not sure if I know how to code 3 and more modes then allow user to select different mode, properly keep different inputs in different variables in different modes, and invalidate invalid input in one single program yet.