Skip to content

Pr/475 - PATCH RELEASE #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vscheuber merged 2 commits into from
Jan 21, 2025
Merged

Pr/475 - PATCH RELEASE #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae6230c
Fix a bug with journey imports where it was importing scripts as a si…
phalestrivir Dec 4, 2024
492204a
fix vulnerabilities
vscheuber Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions src/ops/JourneyOps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,7 +1272,8 @@ export async function exportJourney({
});
scriptObject.script = useStringArrays
? convertBase64TextToArray(scriptObject.script)
: JSON.stringify(decode(scriptObject.script));
: // Stringify necessary to export journey scripts in the same format as Ping AIC
JSON.stringify(decode(scriptObject.script));
exportData.scripts[scriptObject._id] = scriptObject;

// handle library scripts
Expand All @@ -1286,7 +1287,8 @@ export async function exportJourney({
name2uuid[scriptName] = libScriptObject._id;
libScriptObject.script = useStringArrays
? convertBase64TextToArray(libScriptObject.script as string)
: JSON.stringify(decode(scriptObject.script));
: // Stringify necessary to export journey scripts in the same format as Ping AIC
JSON.stringify(decode(scriptObject.script));
exportData.scripts[libScriptObject._id] = libScriptObject;
}
}
Expand Down Expand Up @@ -1566,7 +1568,8 @@ export async function importJourney({
scriptObject['script']
);
} else if (!isBase64Encoded(scriptObject['script'])) {
scriptObject['script'] = encode(scriptObject['script']);
// JSON.parse is necessary to import scripts, otherwise it imports them as a single string
scriptObject['script'] = encode(JSON.parse(scriptObject['script']));
}
try {
await updateScript({ scriptId, scriptData: scriptObject, state });
Expand Down
Loading
Loading