Fix bug with Journey Imports #475
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phalestrivir
force-pushed
the
fix/fix-journey-imports
branch
from
98c8e1c to
ae6230c
Compare
Closed
Contributor
Author
|
Merge in this PR first so that the pipeline doesn't fail when this is merged in. |
Contributor
|
Merged through #484 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug mentioned in this issue: rockcarver/frodo-cli#457
A few comments were also added to clarify why we use
JSON.stringifyandJSON.parsefor scripts in journey exports and imports.This update broke a few of the journey import tests in frodo-cli, so I made a PR there as well to fix those tests.