Skip to content

delete the objects owned by the widget #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

delete the objects owned by the widget #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Vizkit3DWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,16 @@ Vizkit3DWidget::Vizkit3DWidget( QWidget* parent,int width,int height,const QStri
_timer.start(10);
}

Vizkit3DWidget::~Vizkit3DWidget() {}
Vizkit3DWidget::~Vizkit3DWidget()
{
delete env_plugin;
env_plugin = NULL;
Copy link

@doudou doudou Jan 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're using C++ >= 11, use nullptr instead of NULL.

while (!plugins.empty()) {
auto plugin = plugins.begin()->first;
deregisterDataHandler(plugin);
delete plugin;
}
}

//qt ruby is crashing if we use none pointer here
QStringList* Vizkit3DWidget::getVisualizationFramesRuby() const
Expand Down