Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Task from Roc #7487

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Conversation

smores56
Copy link
Collaborator

@smores56 smores56 commented Jan 9, 2025

Fully removes Task and the ! suffix from Roc. If you grep for it, there are only a couple places left where you'll find it:

  • The website which should be updated separately
  • In some already out-of-date docs in README's like test platforms, those should also be updated more comprehensively in a different PR
  • Syntax tests that don't actually use Task to run code

Also, this re-removes the examples as was done in this PR after a merge failure caused them to be re-added.

Copy link
Collaborator

@lukewilliamboswell lukewilliamboswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 😄

Also tested this against basic-cli & basic-webserver with all tests ✅

@lukewilliamboswell lukewilliamboswell merged commit ee54aca into roc-lang:main Jan 9, 2025
16 of 19 checks passed
@smores56 smores56 deleted the remove-task branch January 9, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants