Skip to content

Upgrade to snake_case builtins and initial PNC #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Anton-4 merged 21 commits into from
Jan 25, 2025
Merged

Upgrade to snake_case builtins and initial PNC #93

Anton-4 merged 21 commits into from
Jan 25, 2025

Conversation

@lukewilliamboswell
Copy link
Collaborator

@lukewilliamboswell lukewilliamboswell commented Jan 9, 2025

No description provided.

@lukewilliamboswell lukewilliamboswell mentioned this pull request Jan 9, 2025
Closed
@lukewilliamboswell lukewilliamboswell marked this pull request as ready for review January 9, 2025 00:29
@lukewilliamboswell
Copy link
Collaborator Author

lukewilliamboswell commented Jan 9, 2025

Requires a release of basic-cli from roc-lang/basic-cli#305 to build and run CI. All tests passing locally in nix.

smores56
smores56 requested changes Jan 9, 2025
View reviewed changes
smores56
smores56 previously approved these changes Jan 9, 2025
View reviewed changes
@Anton-4
Copy link
Collaborator

Anton-4 commented Jan 10, 2025

Requires a release of basic-cli from roc-lang/basic-cli#305 to build and run CI. All tests passing locally in nix.

We could download the latest main source of basic-cli and use that with cli: platform "../basic-cli/platform/main.roc",.

smores56
smores56 reviewed Jan 10, 2025
View reviewed changes
Anton-4 and others added 5 commits January 15, 2025 17:06
@Anton-4
update for roc PR 7448
cda794e 
The Cargo.lock update prevents: A reference count was decremented all the way to zero, which should never happen.
@imclerran
Result.map -> Result.map_ok
87b1544
@Anton-4
Merge pull request #94 from imclerran/result-map-ok
be9d1ff 
Result.map -> Result.map_ok
@lukewilliamboswell
update flake
7023422
@lukewilliamboswell
upgrade to latest main -- syntax changes
e1bca83
@lukewilliamboswell
Copy link
Collaborator Author

lukewilliamboswell commented Jan 24, 2025

Probably related to this upgrade... I'm not sure what is causing this. But I'm seeing the below issue in lukewilliamboswell/roc-htmx-tailwindcss-demo#6

$ ./build.sh
<snipped>
2025-01-24T05:16:18Z GET /
server(41406,0x16eb93000) malloc: *** error for object 0x102f50000: pointer being freed was not allocated
server(41406,0x16eb93000) malloc: *** set a breakpoint in malloc_error_break to debug

smores56
smores56 previously approved these changes Jan 25, 2025
View reviewed changes
@Anton-4 Anton-4 merged commit b10860e into main Jan 25, 2025
4 checks passed
@Anton-4 Anton-4 deleted the snake_case_builtins branch January 25, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smores56 smores56 smores56 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lukewilliamboswell @Anton-4 @smores56 @imclerran