Repository navigation
Fix nightly compatibility and prepare 0.28.1 - #557
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The November 13 Roc nightly reports six duplicate-definition warnings in basic-cli 0.28.0. Move the opaque command implementation beside the
Cmdnamespace and keepCmd.Commandas its public alias; rename the two shadowingPath.parentclosure parameters. Existing command signatures, method lookup, docs, and opacity are preserved.Upgrade CI, release builds, docs, and the Nix development shell to the latest published nightly,
nightly-2026-11-13-03dce41. It contains roc-lang/roc#12996, which fixes the Windows compile-time literal failures in #555. Add an uncached platform check to source validation so both warnings and literal evaluation failures fail CI. Use the official nightly for static runtime validation, retaining native execution, PIE/ASLR, and development-backend callback coverage. Nix temporarily supplements the upstream overlay with official archive hashes because its metadata currently stops at November 12.Prepare version 0.28.1 and release notes, including the entry-point argument annotation from #554. Native linker inputs remain pinned to the existing verified artifacts.
Validation (all CI green at
5032f62):scripts/test.py: source checks, all 758 platform tests, host tests, example builds, and native run cases passed.roc bumpagainst 0.28.0: no public API changes; 0.28.1 satisfies the patch bump.Cmd.Commandand its methods.Cmd.Commandis opaque.Closes #556.
Closes #555.