Skip to content

Conversation

@winkler1
Copy link
Contributor

@winkler1 winkler1 commented Feb 9, 2017

No description provided.

@stubailo
Copy link
Collaborator

stubailo commented Feb 9, 2017

Oh looks like we both created a React-Apollo starter in parallel! I'll take a look tonight and see if we can just merge them together :]

@winkler1
Copy link
Contributor Author

winkler1 commented Feb 9, 2017

@stubailo Sounds good 👍

@@ -0,0 +1,201 @@
Apache License
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't an MIT license be better? This means any project started from this kit would be burdened with a more restrictive license.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, or maybe remove entirely? Just got created from create-react-app....

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, that's really surprising that CRA adds the Apache license. I do think having a permissive license is important.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad... CRA does not add a license; that came from GH on new repo

@stubailo
Copy link
Collaborator

I think this example is a bit more in-depth than mine btw, the easiest thing might be to have both.

@winkler1
Copy link
Contributor Author

Your code is more elegant (functional components; recompose is interesting). This one has an example mutation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants