Coverity fixes - initializations_1 #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damn1
requested review from
barbalberto,
drdanz,
randaz81 and
traversaro
as code owners
damn1
changed the title
damn1
changed the title
|
I'll have to fix this PR given this MVSC feature: |
damn1
force-pushed
the
coverityFix_uninit1
branch
from
684c15b to
11fcc2a
Compare
damn1
changed the title
Nicogene
added
PR Status: Changelog - Not Required
damn1
force-pushed
the
coverityFix_uninit1
branch
from
11fcc2a to
a664d94
Compare
drdanz
suggested changes
Nov 27, 2017
| @@ -12,6 +12,7 @@ | |||
|
|
|||
| #include <csetjmp> | |||
| #include <cstdio> | |||
| #include <string.h> | |||
There was a problem hiding this comment.
please use cstring instead of string.h
| @@ -10,6 +10,7 @@ | |||
| #include <cstdio> | |||
| #include <cstdlib> | |||
| #include <portaudio.h> | |||
| #include <string.h> | |||
| m_do_not_clip_infinity_enable(false), | ||
| m_inExpressMode(false), | ||
| m_pwm_val(0), | ||
| m_device_status(DEVICE_OK_STANBY), |
There was a problem hiding this comment.
I did not check this, but "STANBY" looks like a typo...
There was a problem hiding this comment.
That's the actual name of the status
damn1
force-pushed
the
coverityFix_uninit1
branch
from
a664d94 to
67e2fe4
Compare
drdanz
force-pushed
the
coverityFix_uninit1
branch
from
67e2fe4 to
c0982d6
Compare
drdanz
approved these changes
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some 'uninitialized pointer or scalar field' issues raised by Coverity.
Affect components