Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed classes SearchReport, SearchMonitor #3059

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Removed classes SearchReport, SearchMonitor #3059

merged 8 commits into from
Dec 11, 2023

Conversation

randaz81
Copy link
Member

@randaz81 randaz81 commented Dec 7, 2023 •
edited
Loading

Removed classes:
yarp::os::SearchReport
yarp::os::SearchMonitor

Their functionality (i.e. collecting and printing the list of the parameters searched by a device through methods find, findGroup etc.) will be reintroduced in a subsequent PR using a different mechanism.

  • This PR does not break the CI.
  • Parameters interface/handler implemented by PR: IDeviceDriverParams  #3060
  • Paramaters parser generator implemented by PR: XXXXXX
  • Parameters listing functionality in yarpdev broken. Functionality implemented in PR: XXXXXX
  • Harness_devices removed. Functionality implemented by PR: XXXXX
  • RobotDescriptionServer broken. Functionality implemented by PR: XXXXX
  • Yarpdev terminator port name broken. Functionality implemented by PR: XXXXX

@randaz81
Removed classes:
d921320 
-SearchReport
-*SearchMonitor
@randaz81 randaz81 self-assigned this Dec 7, 2023
@update-docs Update Docs
Copy link

update-docs bot commented Dec 7, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

@randaz81
Further refactor.
2cc537f 
This commit intentionally breaks some internals of:
- harness_devices
- RobotDescriptionServer
- yarpdev terminator port name (now /yarpdev)
- yarpdev toDox method
@randaz81 randaz81 force-pushed the removed_SearchReport branch from 244b469 to 2cc537f Compare December 8, 2023 12:31
@randaz81 randaz81 force-pushed the removed_SearchReport branch from a3b9237 to 588596f Compare December 9, 2023 14:30
@randaz81
DynamixelAX12 device fix
bc2d424 
Bindings fix
Fixed destructor of DeviceDriver class
@randaz81 randaz81 force-pushed the removed_SearchReport branch from 588596f to bc2d424 Compare December 11, 2023 08:54
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 8 Code Smells

4.2% 4.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@randaz81 randaz81 merged commit 5da2e15 into robotology:master Dec 11, 2023
50 of 52 checks passed
@traversaro traversaro mentioned this pull request Dec 18, 2023
Closed
This was referenced Feb 29, 2024
Closed
Closed
Closed
@traversaro traversaro mentioned this pull request Jul 31, 2024
Closed
@pattacini pattacini mentioned this pull request Aug 2, 2024
Merged
@randaz81 randaz81 deleted the removed_SearchReport branch November 12, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro Awaiting requested review from traversaro traversaro is a code owner

@Nicogene Nicogene Awaiting requested review from Nicogene Nicogene is a code owner

Assignees

@randaz81 randaz81

Labels
Component: Library - YARP_os
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@randaz81