Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icub-tests repository #93

Merged
merged 3 commits into from
Jun 23, 2018
Merged

Add icub-tests repository #93

merged 3 commits into from
Jun 23, 2018

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Jun 21, 2018

This PR adds the icub-tests repository to the superbuild. I'm not yet sure that the CORE profile is the best location, let me know what you think.

Closes #3.

Blocked by robotology/icub-tests#41.

cc @traversaro

YARP_DATA_DIRS should contain the suits folder of the source tree
@traversaro
Copy link
Member

I guess it will be CORE, unless someone proposes a better solution before the merge.

@traversaro
Copy link
Member

Travis is failing because robotology-superbuild is still using GCC 4.8 . Opening a PR for that now.

Copy link
Member

@traversaro traversaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YARP_DATA_DIRS is not updated in the Windows docs. (I know this is annoying, but it is meant to be: I seriously think that a sane setup procedure cannot depend on dozens of env variables, and at least in the README we can keep track of this complexity).

@diegoferigo
Copy link
Member Author

Done thanks!

@traversaro traversaro merged commit db0f683 into robotology:master Jun 23, 2018
@traversaro
Copy link
Member

Merged, thanks!

@diegoferigo diegoferigo deleted the feature/icub-tests branch June 23, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants