Add dependency on onnruntime-cpp also on conda if ROBOTOLOGY_ENABLE_DYNAMICS_FULL_DEPS is enabled#1575
Merged
Merged
Conversation
…YNAMICS_FULL_DEPS is enabled
Member
Author
|
(Please ignore the failures in Debian Buster) |
traversaro
requested review from
LoreMoretti
and removed request for
lrapetti
Member
Author
|
Sorry for the noise @lrapetti, as usual I actually I wanted the review from @LoreMoretti not from you . I hope @alecive will not notice this. :D |
LoreMoretti
approved these changes
Jan 25, 2024
Contributor
LoreMoretti
left a comment
LoreMoretti
left a comment
There was a problem hiding this comment.
I have compiled and installed it, and everything is working. Approving.
Member
No problem, anyway LGTM 😉 |
Member
Author
|
Thanks for all the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes what we started in #1387, as now conda-forge/onnxruntime-feedstock#56 is solved.
The corresponding change in the blf conda-forge recipe was made in conda-forge/bipedal-locomotion-framework-feedstock#53 .