Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YARP 3 and Gazebo 9 cleanup #367

Merged
merged 3 commits into from
Jun 11, 2018
Merged

YARP 3 and Gazebo 9 cleanup #367

merged 3 commits into from
Jun 11, 2018

Conversation

traversaro
Copy link
Member

  • Remove usage of YARP_INCLUDE_DIRS CMake variable : 251ff24
  • yarp::os::ConstString ---> std::string : 8e09d7b
  • Fix Gazebo 9 deprecation : bb6ef7b

@traversaro traversaro requested review from diegoferigo and jeljaik June 6, 2018 13:49
@traversaro
Copy link
Member Author

The docker images need to be updated.

diegoferigo
diegoferigo approved these changes Jun 7, 2018
View reviewed changes
Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really have to find a way to schedule the automatic generation of images. I'll take care of this.

@traversaro
Copy link
Member Author

docker images generation currently failing due to the icub-tests , due to robotology/yarp#1735 (pending fix in robotology/icub-tests#41) and robotology/yarp#1736 .

@traversaro
Copy link
Member Author

Merging as the CI will be probably broken by something else.

@traversaro traversaro merged commit dc448fd into robotology:devel Jun 11, 2018
@traversaro traversaro deleted the fix/yarp3 branch June 11, 2018 16:53
@diegoferigo
Copy link
Member

@traversaro Images are again misaligned after the Yarp 3.0 release. Need some time to sync. Will be fixed soon 😉

@traversaro
Copy link
Member Author

@diegoferigo yep, but anyway robotology/yarp#1736 is still present, so I think it make sense to move forward without CI for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegoferigo diegoferigo diegoferigo approved these changes

@jeljaik jeljaik Awaiting requested review from jeljaik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traversaro @diegoferigo