Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core system for Metrics #1442

Merged
merged 32 commits into from
Aug 28, 2024
Merged

Core system for Metrics #1442

merged 32 commits into from
Aug 28, 2024

Conversation

LinasKo
Copy link
Contributor

@LinasKo LinasKo commented Aug 12, 2024

Description

This PR adds metrics as a standalone supervision module.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

  • At the time of opening the draft PR, I'm till writing tests for it.
  • I timed the code, making sure it doesn't add much overhead.
  • I'll try using it in a few application, checking that it's pleasant to use.

Any specific deployment considerations

If we'll want pandas to work, we'll need to do pip install 'supervision[metrics]'.

Docs

  • Docs updated? What were the changes:

Not updated, but they should be.

Sorry, something went wrong.

* Refactored code
* Removed None returns from InternalDataStore
* Removed support for np.ndarray inputs in IntersectionOverUnion
* This commit is in a messy state - tests were not adapted to new metrics.core
* MeanAveragePrecision is incomplete
@LinasKo LinasKo force-pushed the feat/metrics-module-initial branch from b1f2f6b to ab76a47 Compare August 16, 2024 07:02
@LinasKo LinasKo force-pushed the feat/metrics-module-initial branch 3 times, most recently from fcf2edf to 8905768 Compare August 23, 2024 15:51
@LinasKo
Copy link
Contributor Author

LinasKo commented Aug 23, 2024

Here's the status of metrics at the moment:

  • mAP is now supported, for masks and boxes
  • mAP returns results for all, small, medium, and large objects

To change:

  • mAP uses prior IoU function rather than metrics I'll keep it this way during this release.
  • IoU metric on masks is much slower, and produces different results
  • No plotting function for mAP results
  • Not added: mAR
  • Untested at scale
  • Commits need squishing

@LinasKo LinasKo force-pushed the feat/metrics-module-initial branch from b475c21 to 0c6def1 Compare August 26, 2024 12:32
@LinasKo LinasKo marked this pull request as ready for review August 26, 2024 14:08
@LinasKo LinasKo force-pushed the feat/metrics-module-initial branch from ab2c233 to 1d7bf88 Compare August 27, 2024 09:45
@LinasKo LinasKo force-pushed the feat/metrics-module-initial branch from 1d7bf88 to 84bb44d Compare August 27, 2024 11:50
@LinasKo LinasKo merged commit f1124e0 into develop Aug 28, 2024
9 checks passed
@onuralpszr onuralpszr deleted the feat/metrics-module-initial branch September 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants