Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rtdetr method #1421

Closed
wants to merge 5 commits into from
Closed

Conversation

Bhavay-2001
Copy link
Contributor

@Bhavay-2001 Bhavay-2001 commented Aug 1, 2024

Description

Fixes issue #1418

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Colab notebook

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

Reviewer - @LinasKo @SkalskiP

@LinasKo
Copy link
Contributor

LinasKo commented Aug 1, 2024

Hi @Bhavay-2001,

I see this is coming from transformers. If that's the case, the model should already be supported via the from_transformers connector.

Note that we may not support post_process_object_detection yet (only the legacy post_process method), but that is already being worked on, on PR #1386.

Are transformers the primary framework for calling this model?

@Bhavay-2001
Copy link
Contributor Author

Bhavay-2001 commented Aug 2, 2024

Hi @Bhavay-2001,

I see this is coming from transformers. If that's the case, the model should already be supported via the from_transformers connector.

Note that we may not support post_process_object_detection yet (only the legacy post_process method), but that is already being worked on, on PR #1386.

Are transformers the primary framework for calling this model?

Yes, I am loading this model from the transformers library of hugging face.

@Bhavay-2001
Copy link
Contributor Author

Hi @LinasKo, should I close this one for now?

@LinasKo
Copy link
Contributor

LinasKo commented Aug 5, 2024

Hey @Bhavay-2001,

Yes, let's close it for now. Thank you for keeping your eyes open for potential improvements. Apologies for not stopping you a bit earlier - I wasn't sure if RT-DETR is standalone or primarily a transformers model. Could have saved you a bit of time 😅

@LinasKo LinasKo closed this Aug 5, 2024
@Bhavay-2001
Copy link
Contributor Author

No worries. There is this issue which requires work on obb. I have worked on obb before so should I try to work on this one?

@Bhavay-2001 Bhavay-2001 deleted the RTDETR_method branch August 5, 2024 09:04
@SkalskiP
Copy link
Collaborator

SkalskiP commented Aug 5, 2024

Hi, @Bhavay-2001 👋🏻 from_transformers works with the RT-DETR transformers model. Take a look here for reference.

@SkalskiP
Copy link
Collaborator

SkalskiP commented Aug 5, 2024

No worries. There is this issue which requires work on obb. I have worked on obb before so should I try to work on this one?

@Bhavay-2001 I think we should finish work on #1409 first.

@Bhavay-2001
Copy link
Contributor Author

No worries. There is this issue which requires work on obb. I have worked on obb before so should I try to work on this one?

@Bhavay-2001 I think we should finish work on #1409 first.

Alright, pls review it whenever you find the time.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants