Update CMakeLists.txt#51
Open
pkohout wants to merge 2 commits into
Open
Conversation
specifically setting c++ version to be 17.
morxa
requested changes
Mar 15, 2022
morxa
left a comment
morxa
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR, it makes sense to set the C++ standard explicitly. However, this should be done with CXX_STANDARD (https://cmake.org/cmake/help/v3.23/prop_tgt/CXX_STANDARD.html), i.e.,
set(CMAKE_CXX_STANDARD 17)
Contributor
Author
|
ups totally forgot about this PR. Good catch, I changed it to using the CMAKE_CXX_STANDARD variable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
While testing the compilation on my other PC I found out that the CMake does not specify the C++ version to be used. If a older version of g++ is installed that leads to a lot of errors (like std::optional is non existing and so on). I specify it now to use c++17. Just wanted to let you know, I guess this might save some time for others.