Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to python #1

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Convert to python #1

merged 6 commits into from
Feb 7, 2024

Conversation

mmokko
Copy link
Contributor

@mmokko mmokko commented Feb 6, 2024

Had to modify the use cases quite heavily.

The Camelot library used to extract tabular data from the PDF haven't been maintained very well for the past year and made the dependency resolution quite difficult so I ended up removing the example. Also the other recommended PDF libraries don't support exporting PDF data to any tabular format.

The open issue from Camelot that required to import outdated Pandas library: camelot-dev/camelot#480

I also removed the DocumentAI example. Kari suggested to move that to be a separate example: https://linear.app/robocorp/issue/DAP-70/add-documentai-example.

@mmokko mmokko requested review from cmin764 and OvidiuCode February 6, 2024 10:04
Copy link

@OvidiuCode OvidiuCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complex stuff but looks good!

Copy link
Contributor

@cmin764 cmin764 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, haven't tested it yet, gj!

Left a couple of questions & nits as it wasn't clear from the code, but no strong opinion on any of them.

PDFMinerLibrary.py Show resolved Hide resolved
PDFMinerLibrary.py Outdated Show resolved Hide resolved
PyPDFLibrary.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
conda.yaml Outdated Show resolved Hide resolved
tasks.py Show resolved Hide resolved
mmokko and others added 5 commits February 6, 2024 13:25
@mmokko mmokko merged commit f8d01d3 into master Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants