-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to python #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complex stuff but looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, haven't tested it yet, gj!
Left a couple of questions & nits as it wasn't clear from the code, but no strong opinion on any of them.
Co-authored-by: Cosmin Poieana <[email protected]>
Co-authored-by: Cosmin Poieana <[email protected]>
Had to modify the use cases quite heavily.
The Camelot library used to extract tabular data from the PDF haven't been maintained very well for the past year and made the dependency resolution quite difficult so I ended up removing the example. Also the other recommended PDF libraries don't support exporting PDF data to any tabular format.
The open issue from Camelot that required to import outdated Pandas library: camelot-dev/camelot#480
I also removed the DocumentAI example. Kari suggested to move that to be a separate example: https://linear.app/robocorp/issue/DAP-70/add-documentai-example.