[codex] Remove retired Windsurf plugin on startup#552
Draft
robinebers wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windsurfplugin folder from the app-data plugin install directory during startup.app_data/plugins/windsurfdirectory.Root Cause
Auto-updated installs keep the persisted app-data plugin directory. The new release stopped bundling Windsurf, but startup only copied bundled plugins into app data and never pruned plugin folders removed from later bundles, so stale Windsurf code could still be discovered and loaded.
Impact
After the next release, upgraded users should no longer see the old Windsurf plugin. The cleanup only removes the retired bundled-code folder when its manifest ID is
windsurf; plugin data and unrelated/custom plugin folders are left alone.Validation
cargo test --libbun run test -- src/lib/settings.test.ts src/hooks/app/use-settings-bootstrap.test.ts --runSummary by cubic
Remove the retired bundled Windsurf plugin on startup and block it from loading. Prevents stale
windsurfcode from old installs from being discovered and run; custom plugins are untouched.app_data/plugins/windsurfonly if its manifest id iswindsurf.Written for commit ad4e69a. Summary will update on new commits.