Skip to content

[codex] Remove retired Windsurf plugin on startup#552

Draft
robinebers wants to merge 1 commit into
mainfrom
codex/remove-retired-windsurf-plugin
Draft

[codex] Remove retired Windsurf plugin on startup#552
robinebers wants to merge 1 commit into
mainfrom
codex/remove-retired-windsurf-plugin

Conversation

@robinebers
Copy link
Copy Markdown
Owner

@robinebers robinebers commented Jun 4, 2026

Summary

  • Remove the retired bundled windsurf plugin folder from the app-data plugin install directory during startup.
  • Filter retired bundled plugin IDs out of plugin loading as a defensive backstop.
  • Add regression coverage for upgraded installs that still have a stale app_data/plugins/windsurf directory.

Root Cause

Auto-updated installs keep the persisted app-data plugin directory. The new release stopped bundling Windsurf, but startup only copied bundled plugins into app data and never pruned plugin folders removed from later bundles, so stale Windsurf code could still be discovered and loaded.

Impact

After the next release, upgraded users should no longer see the old Windsurf plugin. The cleanup only removes the retired bundled-code folder when its manifest ID is windsurf; plugin data and unrelated/custom plugin folders are left alone.

Validation

  • cargo test --lib
  • bun run test -- src/lib/settings.test.ts src/hooks/app/use-settings-bootstrap.test.ts --run

Summary by cubic

Remove the retired bundled Windsurf plugin on startup and block it from loading. Prevents stale windsurf code from old installs from being discovered and run; custom plugins are untouched.

  • Bug Fixes
    • On startup, delete app_data/plugins/windsurf only if its manifest id is windsurf.
    • Filter retired bundled plugin IDs from loading as a safety net.
    • Added regression tests for upgraded installs and legacy/mismatched directories.

Written for commit ad4e69a. Summary will update on new commits.

Review in cubic

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f818f46c-3c2e-42d1-942d-b8aac6fd0584

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/remove-retired-windsurf-plugin

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the rust Pull requests that update rust code label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant