feat: Tray/Dock app position with draggable, centered Dock window#546
Draft
robinebers wants to merge 1 commit into
Draft
feat: Tray/Dock app position with draggable, centered Dock window#546robinebers wants to merge 1 commit into
robinebers wants to merge 1 commit into
Conversation
Adds an "App Position" setting (Tray vs Dock, default Tray) so the app shows EITHER the menu bar (tray) icon OR the Dock icon, never both, to save tray space. The choice persists across restarts and is applied natively at startup. In Dock mode the panel behaves like a normal window: centered on launch, draggable via the sidebar (deep drag region, interactive icons excluded), and it stays open on blur (Escape still hides). A "Always keep on top" toggle (Dock-only, default off) floats the window above other windows. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
woow thank you |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an app position setting to OpenUsage so that you can either show the app in the macOS tray or in the macOS dock. When docked, the sidebar becomes draggable And there is a conditional setting to always show the app on top of all other apps.
This is NOT finished. But I'm creating the draft now to see if there's any demand for this.
Todo
Test plan
bunx tsc --noEmitcargo check+cargo clippy(no new warnings)bunx vitest run(affected suites) — settings, side-nav, app-content, bootstrap, system-actionsSummary by cubic
Adds an App Position setting to choose Tray or Dock so the app shows either the menu bar icon or the Dock icon, never both. Default is Tray; in Dock mode the window is centered, draggable, persists on blur, and can be kept on top.
update_dock_icon_visibility,update_always_on_top, andcore:window:allow-start-dragging.Written for commit 5f1cd71. Summary will update on new commits.