avoid panic on unknown escape sequence

robfig · Jul 16, 2020 · 54e9f54 · 54e9f54
1 parent ed3d69b
commit 54e9f54
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/parse/quote.go b/parse/quote.go
@@ -76,7 +76,7 @@ func unquoteString(s string) (string, error) {
 			} else {
 				replacement, ok := unescapes[r]
 				if !ok {
-					return "", errors.New("unrecognized escape code: \\" + s[i:i+1])
+					return "", errors.New("unrecognized escape code: \\" + s[i-1:i])
 				}
 				r = rune(replacement)
 			}

diff --git a/parse/quote_test.go b/parse/quote_test.go
@@ -41,3 +41,17 @@ func TestUnquote(t *testing.T) {
 		}
 	}
 }
+
+func TestUnquoteUnrecognized(t *testing.T) {
+	var tests = []string{
+		`'\0'`,
+		`'\a'`,
+		`'\z'`,
+	}
+	for _, tc := range tests {
+		_, err := unquoteString(tc)
+		if err == nil {
+			t.Errorf("expected unrecognized escape sequence %s to fail", tc)
+		}
+	}
+}