flash selected widget #21
Conversation
Support for functor arguments was added in Qt 5.4.
robertknight
left a comment
robertknight
left a comment
There was a problem hiding this comment.
I think this is a good idea for a feature. I found a bug where the flash effect can remain on if you click the button a second time while the sequence is running. There is also a problem that the effect is not always visible depending on how stylesheets interact with the widget's own drawing. It might work better to place an overlay above the part of the window where the flashed widget is and apply styling in that. This would need to be done from the injected library rather than the inspector.
|
|
||
| QTimer::singleShot(500, [=]() { object->writeProperty("styleSheet", origStyle); }); | ||
| QTimer::singleShot(1000, [=]() { object->writeProperty("styleSheet", newStyle); }); | ||
| QTimer::singleShot(1500, [=]() { object->writeProperty("styleSheet", origStyle); }); |
There was a problem hiding this comment.
I added a version check around these calls, as support for functor arguments to QTimer::singleShot was added only in Qt 5.4. The project ostensibly still supports Qt 4, although I think that support could probably be ended now.
| QString origStyle; | ||
| for (const auto &property : object->properties()) | ||
| { | ||
| if (property.name == "styleSheet") |
There was a problem hiding this comment.
If the widget is in the middle of an earlier flash sequence when the button is clicked, this loop may capture the flashed stylesheet. The result is that the flash effect remains on at the end of the sequence.
2 participants
Example: https://www.dropbox.com/s/b9crdk7t2lkodlr/qt-inspector.MP4?dl=0