Updating experimantal feature branch #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#1152] Emit error in case the module name does not coincide with the filename
In case of unparsable forms, try removing some trailing tokens, this way the first half of the form could be parsed and POIs extracted. related to #1037
Parse incomplete text
[#1050] Add separate way to send log notification to avoid recursion
Related to inaka/elvis_core#220
Precompute list of enabled diagnostics
erlfmt_parser returns a `raw_string` form for comments which are after the last form in the file and not followed by any more form. It was not expected by els_parser that a raw_string can contain no tokens (just comments and whitespace). A file with no code just whitespace has the same result. Fixes #1171
…loading-lsp-mode [#1174] [emacs] Ensure keybinding is configured before loading lsp-mode
Fix parsing trailing comments in modules
Update elvis_core to deal with CRLF line endings
Augment local config onto global config
This fixes an issue where initialization of els distribution would fail due to invalid node name if the project directory contains characters that are not valid in an erlang node name.
* Use same scoping rules as variable renaming * No longer limited to only variables inside functions * Add support for finding variable references
Invalid syntax on the module attribute can cause a crash.
* Fix false positive module name check diagnostic Discovered that modules with whitespace in their name could cause false positives in the module name check diagnostic. Root cause is in els_uri:path/1, since uri_string:normalize/1 return a percent encoded path, we need to percent decode that path to get the real path. * Shouldn't need to handle percent encoding for windows paths any more This change essentially reverts #1017 and adds a unit test * Use http_uri:decode/1 for older OTP releases
* Add better support for completing keywords * Add support for completing map and list comprehensions * Add support for completing type after :: * Add test for completion of comprehensions
Use tokens to generate POIs on lines where parsing fails. Currently handling call(), module:call(), ?MACRO, #record, atom.
Add workflows to build and release on macos.
This will make document formatting use the unsaved state of the file. Fixes #1419 .
* Don't run diagnostics unless indexing is done * Improve performance of crossref diagnostics
If we don't have a precise match, try to find a close match for goto definition, e.g. if we have a(q,w,e) but only a/4 defined jump there. Fixes #1250 .
Also fixes completion for OTP behaviours
* Ignore variables inside funs() and list comprehensions * Don't suggest to extract function unless it contains more than one poi
* Browse elvis warnings * Browse compiler errors * Browse functions and types in otp docs or hex docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.