Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/update mex-common 0.51.0 #332

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Feb 12, 2025

PR Context

  • massive clean-up of mapping types and validity
  • some type-ignores were left in for future generations to enjoy

Changes

  • update mex-common to version 0.51.0
  • use proper mapping models
  • move inline test mappings to /assets with suffix _mock

Removed

  • remove mex.extractors.mapping model in favor of load_yaml and model_validate

Fixed

  • fix setValues listyness of test mappings
  • fix test mapping schema path
  • fix test mapping indentations

Copy link
Contributor

@esinsj esinsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test the code because the changes are not implemented in mex-assets yet ("No such file or directory: '...\mex-assets\mappings\blueant\activity.yaml'")
Otherwise the code looks fine visually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants