Fix delete_transaction_rule reporting successful deletions as failures

[ahnj]

Problem

delete_transaction_rule returns {"success": false, "message": "Rule was not deleted"} for deletions that actually succeed.

Monarch's deleteTransactionRule mutation returns deleted: false with no errors even when the rule was removed. The current guard treats that flag as authoritative:

if delete_result.get("deleted") is False:
    return json_success({"success": False, "message": "Rule was not deleted"})

This is more than cosmetic — the tool reports a completed destructive operation as not having happened, which invites the caller to retry or to act on state they believe is still present.

Verification against the live API

Deleted four real rules. Every call returned deleted: false; all four were genuinely gone, confirmed by re-querying the rule list (the IDs were absent) and by the total count dropping from 322 to 318.

Genuine failures never reach that branch. Deleting a non-existent rule raises TransportQueryError from the GraphQL layer:

gql.transport.exceptions.TransportQueryError:
{'message': 'Not found', 'path': ['deleteTransactionRule']}

which the surrounding except Exception already turns into an error result.

Change

Drop the deleted check. The explicit errors payload check is left in place as the only trustworthy in-payload failure signal.

Tests

test_delete_rule_not_found passed before and after because it mocks deleted: false together with an errors object, so the errors branch catches it first — the real-world shape was never covered.

Added test_delete_rule_success_with_false_deleted_flag for deleted: false + errors: None. It fails before this change and passes after. Full suite: 223 passed.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KTJGjJh4qNHBGWdZW3UDPo