Skip to content

chore: HorshamDistrictCouncil - use retry session for resilience - #2161

Closed
robbrad wants to merge 1 commit into
masterfrom
chore/horsham-retry-hardening
Closed

robbrad wants to merge 1 commit into
masterfrom
chore/horsham-retry-hardening

Conversation

@robbrad

@robbrad robbrad commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Summary

Minor hardening found while triaging the full council suite - Horsham's scraper used a plain `requests.Session()` with no retry logic, and is currently hitting `ConnectionResetError`. Switched to the existing `build_retry_session()` helper for consistency with the rest of the codebase.

Note: this does not fix the council's current failure - verified live that it still fails after 5 retries, so this is a sustained block/outage on their end, not a transient blip retries can paper over. Keeping this as defensive hardening for future transient issues; the live failure needs separate investigation (not done here).

Test plan

  • black --check clean
  • Confirmed no behavior change for the success path (same headers, same request shape)

Matches the retry/backoff pattern already used elsewhere in the
codebase. Doesn't fix the council's current persistent connection
reset (verified live: still fails after 5 retries, so this is a
sustained block/outage, not a transient blip) - this is defensive
hardening for future transient failures, not a fix for the live issue.
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@robbrad, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c5243401-95fe-47eb-9b75-ea7d1fc2f7c1

📥 Commits

Reviewing files that changed from the base of the PR and between 46d94c1 and 7a5a585.

📒 Files selected for processing (1)
  • uk_bin_collection/uk_bin_collection/councils/HorshamDistrictCouncil.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/horsham-retry-hardening

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.89%. Comparing base (4d6f787) to head (7a5a585).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2161   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files           9        9           
  Lines        1160     1160           
=======================================
  Hits         1008     1008           
  Misses        152      152           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@robbrad

robbrad commented Jul 13, 2026

Copy link
Copy Markdown
Owner Author

Folded into #2163 to keep this to a single PR. Closing this one - the commit is now part of #2163's branch.

@robbrad robbrad closed this Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant