Repository navigation
Conversation
SouthKestevenDistrictCouncil's OCR-based scraper (the only consumer of the ocr extra) was fully replaced by #2121's rewrite - nothing in the codebase imports easyocr or torch anymore. Removing the extra drops easyocr, pillow, and the ~24 interlocking nvidia/cuda transitive packages that came with it, and makes the pending torch version-bump PR (#2129) unnecessary.
Contributor
📝 WalkthroughWalkthroughThe Poetry dependency list is reorganized so ChangesDependency declarations
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2156 +/- ##
=======================================
Coverage 86.88% 86.88%
=======================================
Files 9 9
Lines 1159 1159
=======================================
Hits 1007 1007
Misses 152 152 ☔ View full report in Codecov by Harness. |
3 tasks done
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
master.easyocr, which was only ever used bySouthKestevenDistrictCouncil's old OCR-based scraper. That scraper was fully replaced by Fix South Kesteven binday scraper #2121's rewrite - grepped the whole codebase and nothing importseasyocrortorchanymore.ocrextra (easyocr,pillow) entirely and regeneratespoetry.lock, which dropstorchand the full nvidia/cuda chain with it (net -897 lines in the lock file).Once this merges, #2129 becomes moot (torch will no longer be a dependency at all) and can be closed.
Side effect
No council or HA behaviour changes at all - nothing in the codebase used
easyocr/torch. The only way this could affect anyone is if someone haspip install uk_bin_collection[ocr]pinned somewhere outside this repo; that install would start failing with "extra not found" after this merges. Given the extra was already dead weight (its sole consumer was removed by #2121), this seems very unlikely to affect anyone in practice.Test plan
poetry run pytest uk_bin_collection/tests custom_components/uk_bin_collection/tests --ignore=uk_bin_collection/tests/step_defs/- 221 passedeasyocr/torch/theocrextra anywhere in the codebase, CI workflows, or docsSummary by CodeRabbit