Attributes as ExpressibleByDictionaryLiteral #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an experiment, not sure if it's a good idea.
I figured that it's nice to keep the declaration order of attributes.
Previously, we were sorting the attributes alphabetically during pretty printing so that they would at least always print in the same order.
Here are a few things to think about:
Tags.swift
compile is just a way to get this out without a large diff. But it also shows a problem: if people buildup their attributes using dictionaries, this approach is not nice. We could makeAttributes
conform to more protocols so that it feels just like an (ordered) dictionary.