Remove Faraday dependency and move to depending on Yammer's Yam gem#9
Open
synth wants to merge 16 commits intoroadly:masterfrom
Open
Remove Faraday dependency and move to depending on Yammer's Yam gem#9synth wants to merge 16 commits intoroadly:masterfrom
synth wants to merge 16 commits intoroadly:masterfrom
Conversation
…m for all api and connection related functionality
|
Might you like to checkout a version of the Yammer gem that I have been working on. https://github.com/tiabas/yammer-client |
Author
|
@tiabas this looks similar to roadly's yammer gem, no? I still see an advantage to depending on Yammer's own yam gem so that if something like the endpoint changes, downstream dependencies will be updated right away rather than relying on third party gem's to update themselves. The api you have built looks nice though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured it would be more reliable to use Yammer's Yam gem to handle the low level requests, but I liked your high level abstraction, so I made this gem depend on Yam instead of calling Faraday directly.
Definitely needs some code review though, but its working for me on my production app now...