Remove IntegrityOption and require metadata and value/type validation always

Fake4Dataverse.sln

@@ -3,44 +3,20 @@ Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio Version 17
 VisualStudioVersion = 17.0.31903.59
 MinimumVisualStudioVersion = 10.0.40219.1
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Fake4DataverseAbstractions", "Fake4DataverseAbstractions", "{AE224DC7-5ADE-BBB7-E55B-0863E083D303}"
-EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{F2891E2B-3F2F-2718-72F2-096F70D30A97}"
-EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Fake4Dataverse.Abstractions", "Fake4DataverseAbstractions\Fake4Dataverse.Abstractions\Fake4Dataverse.Abstractions.csproj", "{4BB8C275-BA62-485E-8F1D-36E9FC0DB9C1}"
 EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{3635BF71-6E28-00B7-6995-FF0886FCE51A}"
-EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Fake4Dataverse.Abstractions.Tests", "Fake4DataverseAbstractions\Fake4Dataverse.Abstractions.Tests\Fake4Dataverse.Abstractions.Tests.csproj", "{0B1D7288-E523-444A-8831-0A04349A0123}"
 EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Fake4DataverseCore", "Fake4DataverseCore", "{09FF767E-0E9C-FF2C-F325-53317B5487EC}"
-EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{6A765392-F65A-FB26-7EB0-AE5D87E1C0F3}"
-EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Fake4Dataverse.Core", "Fake4DataverseCore\Fake4Dataverse.Core\Fake4Dataverse.Core.csproj", "{C7D744FF-D642-4B94-BD81-55A7E81BA4B2}"
 EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{055CC6AB-2088-5AF0-ECFD-464EDA4CBF8F}"
-EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Fake4Dataverse.Core.Tests", "Fake4DataverseCore\Fake4Dataverse.Core.Tests\Fake4Dataverse.Core.Tests.csproj", "{779CB643-978C-4D1A-AEEE-FDEC947E4C9F}"
 EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Fake4Dataverse", "Fake4Dataverse", "{ACB571F4-FAB8-F362-DC53-6A1F11D76ACF}"
-EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{103BF730-FD96-80C7-4CC7-6179574EDADC}"
-EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Fake4Dataverse", "Fake4Dataverse\Fake4Dataverse\Fake4Dataverse.csproj", "{061C9728-EED8-411B-AC8A-4F740C0BF921}"
 EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{4DE1386F-197A-AC13-67B7-DA1E9DEF4CD8}"
-EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Fake4Dataverse.Tests", "Fake4Dataverse\Fake4Dataverse.Tests\Fake4Dataverse.Tests.csproj", "{4D2D4614-7A5B-48D2-8AF8-A42BE60EBD49}"
 EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Fake4DataverseService", "Fake4DataverseService", "{7026A9A1-AB4F-E12C-04FD-EBA544125FD6}"
-EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{2DE68AAB-3AA0-CF3A-3C08-C68BF4CCAF5D}"
-EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Fake4Dataverse.Service", "Fake4DataverseService\Fake4Dataverse.Service\Fake4Dataverse.Service.csproj", "{7E5BCAD4-7795-447A-8A6A-3F297A68393A}"
 EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "tests", "tests", "{B48F1246-51EC-A51C-ABAF-BBF8736814D3}"
-EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Fake4Dataverse.Service.Tests", "Fake4DataverseService\Fake4Dataverse.Service.Tests\Fake4Dataverse.Service.Tests.csproj", "{AB0662A7-3B62-41E2-95AD-9E414D799B70}"
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Fake4Dataverse.Service.IntegrationTests", "Fake4DataverseService\Fake4Dataverse.Service.IntegrationTests\Fake4Dataverse.Service.IntegrationTests.csproj", "{3F497949-98FC-4A1D-A61D-56ACFD8AC99F}"
@@ -167,23 +143,4 @@ Global
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
 	EndGlobalSection
-	GlobalSection(NestedProjects) = preSolution
-		{F2891E2B-3F2F-2718-72F2-096F70D30A97} = {AE224DC7-5ADE-BBB7-E55B-0863E083D303}
-		{4BB8C275-BA62-485E-8F1D-36E9FC0DB9C1} = {F2891E2B-3F2F-2718-72F2-096F70D30A97}
-		{3635BF71-6E28-00B7-6995-FF0886FCE51A} = {AE224DC7-5ADE-BBB7-E55B-0863E083D303}
-		{0B1D7288-E523-444A-8831-0A04349A0123} = {3635BF71-6E28-00B7-6995-FF0886FCE51A}
-		{6A765392-F65A-FB26-7EB0-AE5D87E1C0F3} = {09FF767E-0E9C-FF2C-F325-53317B5487EC}
-		{C7D744FF-D642-4B94-BD81-55A7E81BA4B2} = {6A765392-F65A-FB26-7EB0-AE5D87E1C0F3}
-		{055CC6AB-2088-5AF0-ECFD-464EDA4CBF8F} = {09FF767E-0E9C-FF2C-F325-53317B5487EC}
-		{779CB643-978C-4D1A-AEEE-FDEC947E4C9F} = {055CC6AB-2088-5AF0-ECFD-464EDA4CBF8F}
-		{103BF730-FD96-80C7-4CC7-6179574EDADC} = {ACB571F4-FAB8-F362-DC53-6A1F11D76ACF}
-		{061C9728-EED8-411B-AC8A-4F740C0BF921} = {103BF730-FD96-80C7-4CC7-6179574EDADC}
-		{4DE1386F-197A-AC13-67B7-DA1E9DEF4CD8} = {ACB571F4-FAB8-F362-DC53-6A1F11D76ACF}
-		{4D2D4614-7A5B-48D2-8AF8-A42BE60EBD49} = {4DE1386F-197A-AC13-67B7-DA1E9DEF4CD8}
-		{2DE68AAB-3AA0-CF3A-3C08-C68BF4CCAF5D} = {7026A9A1-AB4F-E12C-04FD-EBA544125FD6}
-		{7E5BCAD4-7795-447A-8A6A-3F297A68393A} = {2DE68AAB-3AA0-CF3A-3C08-C68BF4CCAF5D}
-		{B48F1246-51EC-A51C-ABAF-BBF8736814D3} = {7026A9A1-AB4F-E12C-04FD-EBA544125FD6}
-		{AB0662A7-3B62-41E2-95AD-9E414D799B70} = {B48F1246-51EC-A51C-ABAF-BBF8736814D3}
-		{3F497949-98FC-4A1D-A61D-56ACFD8AC99F} = {B48F1246-51EC-A51C-ABAF-BBF8736814D3}
-	EndGlobalSection
 EndGlobal

Fake4DataverseCore/Fake4Dataverse.Core.Tests/BusinessRules/BusinessRuleExecutorDirectTests.cs

@@ -16,7 +16,7 @@ public class BusinessRuleExecutorDirectTests
         public void Executor_Should_Execute_Simple_Rule_With_Action()
         {
             // Arrange
-            var executor = new BusinessRuleExecutor();
+            var executor = new BusinessRuleExecutor(null);
             var rule = new BusinessRuleDefinition
             {
                 Name = "TestRule",
@@ -55,7 +55,7 @@ public void Executor_Should_Execute_Simple_Rule_With_Action()
         public void Executor_Should_Execute_Rule_Only_When_Condition_Is_Met()
         {
             // Arrange
-            var executor = new BusinessRuleExecutor();
+            var executor = new BusinessRuleExecutor(null);
             var rule = new BusinessRuleDefinition
             {
                 Name = "ConditionalRule",
@@ -108,7 +108,7 @@ public void Executor_Should_Execute_Rule_Only_When_Condition_Is_Met()
         public void Executor_Should_Generate_Error_When_ShowErrorMessage_Action_Executes()
         {
             // Arrange
-            var executor = new BusinessRuleExecutor();
+            var executor = new BusinessRuleExecutor(null);
             var rule = new BusinessRuleDefinition
             {
                 Name = "ValidationRule",
@@ -154,7 +154,7 @@ public void Executor_Should_Generate_Error_When_ShowErrorMessage_Action_Executes
         public void Executor_Should_Execute_ElseActions_When_Conditions_Not_Met()
         {
             // Arrange
-            var executor = new BusinessRuleExecutor();
+            var executor = new BusinessRuleExecutor(null);
             var rule = new BusinessRuleDefinition
             {
                 Name = "ElseRule",

Fake4DataverseCore/Fake4Dataverse.Core.Tests/Extensions/EntityExtensionsTests.cs

@@ -16,7 +16,7 @@ public void SetValueIfEmpty_should_not_override_existing_values()
             e["name"] = "Some name";
 
             e.SetValueIfEmpty("name", "another name");
-            Assert.Equal(e["name"].ToString(), "Some name");
+            Assert.Equal("Some name", e["name"].ToString());
         }
 
         [Fact]
@@ -26,7 +26,7 @@ public void SetValueIfEmpty_should_override_if_null()
             e["name"] = null;
 
             e.SetValueIfEmpty("name", "new name");
-            Assert.Equal(e["name"].ToString(), "new name");
+            Assert.Equal("new name", e["name"].ToString());
         }
 
         [Fact]
@@ -35,7 +35,7 @@ public void SetValueIfEmpty_should_override_if_doesnt_contains_key()
             var e = new Entity("account");
 
             e.SetValueIfEmpty("name", "new name");
-            Assert.Equal(e["name"].ToString(), "new name");
+            Assert.Equal("new name", e["name"].ToString());
         }
 
         [Fact]

Fake4DataverseCore/Fake4Dataverse.Core.Tests/Extensions/EntityMetadataExtensionsTests.cs

@@ -65,7 +65,7 @@ public void SetAttribute_should_not_throw_error()
 
 
             entityMetadata.SetAttribute(fakeAttribute);
-            Assert.Equal(1, entityMetadata.Attributes.Length);
+            Assert.Single(entityMetadata.Attributes);
             Assert.Equal("name", entityMetadata.Attributes[0].LogicalName);
         }
     }

Fake4DataverseCore/Fake4Dataverse.Core.Tests/FakeContextTests/AddToQueueRequestTests/AddToQueueRequestTests.cs

@@ -12,20 +12,7 @@
 namespace Fake4Dataverse.Tests.FakeContextTests.AddToQueueRequestTests
 {
     public class AddToQueueRequestTests : Fake4DataverseTests
-    {
-        private readonly IXrmFakedContext _context;
-        private readonly IOrganizationService _service;
-
-        public AddToQueueRequestTests()
-        {
-            // Use context and service from base class
-
-            _context = base._context;
-
-            _service = base._service;
-        }
-
-        [Fact]
+    {[Fact]
         public void When_can_execute_is_called_with_an_invalid_request_result_is_false()
         {
             var executor = new AddToQueueRequestExecutor();
@@ -51,7 +38,7 @@ public void When_a_request_is_called_New_Queueitem_Is_Created()
                 Id = Guid.NewGuid(),
             };
 
-            _context.Initialize(new[]
+            base._context.Initialize(new[]
             {
                 queue, email
             });
@@ -66,7 +53,7 @@ public void When_a_request_is_called_New_Queueitem_Is_Created()
 
             executor.Execute(req, _context);
 
-            var queueItem = _context.CreateQuery(Crm.QueueItem.EntityLogicalName).Single();
+            var queueItem = base._context.CreateQuery(Crm.QueueItem.EntityLogicalName).Single();
 
             Assert.Equal(queue.ToEntityReference(), queueItem.GetAttributeValue<EntityReference>("queueid"));
             Assert.Equal(email.ToEntityReference(), queueItem.GetAttributeValue<EntityReference>("objectid"));
@@ -91,7 +78,7 @@ public void When_Queue_Item_Properties_Are_Passed_They_Are_Set_On_Create()
                 Id = Guid.NewGuid(),
             };
 
-            _context.Initialize(new[]
+            base._context.Initialize(new[]
             {
                 queue, email
             });
@@ -110,7 +97,7 @@ public void When_Queue_Item_Properties_Are_Passed_They_Are_Set_On_Create()
 
             executor.Execute(req, _context);
 
-            var queueItem = _context.CreateQuery(Crm.QueueItem.EntityLogicalName).Single();
+            var queueItem = base._context.CreateQuery(Crm.QueueItem.EntityLogicalName).Single();
 
             Assert.Equal(queue.ToEntityReference(), queueItem.GetAttributeValue<EntityReference>("queueid"));
             Assert.Equal(email.ToEntityReference(), queueItem.GetAttributeValue<EntityReference>("objectid"));
@@ -143,7 +130,7 @@ public void When_A_Queue_Item_Already_Exists_Use_Existing()
                 ObjectId = email.ToEntityReference()
             };
 
-            _context.Initialize(new[]
+            base._context.Initialize(new[]
             {
                 queue, email
             });
@@ -162,13 +149,13 @@ public void When_A_Queue_Item_Already_Exists_Use_Existing()
 
             executor.Execute(req, _context);
 
-            Assert.Equal(1, _context.CreateQuery(Crm.QueueItem.EntityLogicalName).Count());
+            Assert.Equal(1, base._context.CreateQuery(Crm.QueueItem.EntityLogicalName).Count());
 
-            queueItem = _context.CreateQuery(Crm.QueueItem.EntityLogicalName).Single().ToEntity<QueueItem>();
+            queueItem = base._context.CreateQuery(Crm.QueueItem.EntityLogicalName).Single().ToEntity<QueueItem>();
 
             Assert.Equal(queue.ToEntityReference(), queueItem.GetAttributeValue<EntityReference>("queueid"));
             Assert.Equal(email.ToEntityReference(), queueItem.GetAttributeValue<EntityReference>("objectid"));
             Assert.Equal(workedBy, queueItem.GetAttributeValue<EntityReference>("workerid"));
         }
     }
-}
+}

Fake4DataverseCore/Fake4Dataverse.Core.Tests/FakeContextTests/AddUserToRecordTeamRequestTests/AddUserToRecordTeamRequestTests.cs

@@ -13,20 +13,7 @@
 namespace Fake4Dataverse.Tests.FakeContextTests.AddUserToRecordTeamRequestTests
 {
     public class AddUserToRecordTeamRequestTests : Fake4DataverseTests
-    {
-        private readonly IXrmFakedContext _context;
-        private readonly IOrganizationService _service;
-
-        public AddUserToRecordTeamRequestTests()
-        {
-            // Use context and service from base class
-
-            _context = base._context;
-
-            _service = base._service;
-        }
-
-        [Fact]
+    {[Fact]
         public void When_can_execute_is_called_with_an_invalid_request_result_is_false()
         {
             var executor = new AddUserToRecordTeamRequestExecutor();
@@ -54,7 +41,7 @@ public void When_a_request_is_called_User_Is_Added_To_Record_Team()
                 Id = Guid.NewGuid()
             };
 
-            _context.Initialize(new Entity[]
+            base._context.Initialize(new Entity[]
             {
                 teamTemplate, user, account
             });
@@ -70,21 +57,21 @@ public void When_a_request_is_called_User_Is_Added_To_Record_Team()
 
             executor.Execute(req, _context);
 
-            var team = _context.CreateQuery<Team>().FirstOrDefault(p => p.TeamTemplateId.Id == teamTemplate.Id);
+            var team = base._context.CreateQuery<Team>().FirstOrDefault(p => p.TeamTemplateId.Id == teamTemplate.Id);
             Assert.NotNull(team);
 
-            var teamMembership = _context.CreateQuery<TeamMembership>().FirstOrDefault(p => p.SystemUserId == user.Id && p.TeamId == team.Id);
+            var teamMembership = base._context.CreateQuery<TeamMembership>().FirstOrDefault(p => p.SystemUserId == user.Id && p.TeamId == team.Id);
             Assert.NotNull(teamMembership);
 
-            var poa = _context.CreateQuery("principalobjectaccess").FirstOrDefault(p => (Guid)p["objectid"] == account.Id && 
+            var poa = base._context.CreateQuery("principalobjectaccess").FirstOrDefault(p => (Guid)p["objectid"] == account.Id && 
                                                                                        (Guid)p["principalid"] == team.Id);
             Assert.NotNull(poa);
 
-            var response = _context.GetProperty<IAccessRightsRepository>().RetrievePrincipalAccess(account.ToEntityReference(),
+            var response = base._context.GetProperty<IAccessRightsRepository>().RetrievePrincipalAccess(account.ToEntityReference(),
                 user.ToEntityReference());
             Assert.Equal((AccessRights)teamTemplate.DefaultAccessRightsMask, response.AccessRights);
 
         }
     }
 }
-#endif
+#endif

Fake4DataverseCore/Fake4Dataverse.Core.Tests/FakeContextTests/AssignRequestTests/AssignRequestTests.cs

@@ -13,35 +13,22 @@
 namespace Fake4Dataverse.Tests.FakeContextTests.AssignRequestTests
 {
     public class AssignRequestTests : Fake4DataverseTests
-    {
-        private readonly IXrmFakedContext _context;
-        private readonly IOrganizationService _service;
-
-        public AssignRequestTests()
-        {
-            // Use context and service from base class
-
-            _context = base._context;
-
-            _service = base._service;
-        }
-
-        [Fact]
+    {[Fact]
         public void When_Assigned_Team_As_Owner_OwningTeam_Is_Set()
         {
             var user1 = new SystemUser { Id = Guid.NewGuid(), FirstName = "User1" };
             var team1 = new Team { Id = Guid.NewGuid(), Name = "Team1" };
             var account1 = new Account { Id = Guid.NewGuid(), Name = "Acc1" };
 
-            _context.Initialize(new List<Entity> {
+            base._context.Initialize(new List<Entity> {
                 user1, team1, account1
             });
 
             var executor = new AssignRequestExecutor();
             AssignRequest req = new AssignRequest() { Target = account1.ToEntityReference(), Assignee = team1.ToEntityReference() };
             executor.Execute(req, _context);
 
-            var acc_Fresh = _context.GetOrganizationService().Retrieve(account1.LogicalName, account1.Id, new Microsoft.Xrm.Sdk.Query.ColumnSet(true));
+            var acc_Fresh = base._context.GetOrganizationService().Retrieve(account1.LogicalName, account1.Id, new Microsoft.Xrm.Sdk.Query.ColumnSet(true));
             Assert.Equal(team1.Id, acc_Fresh.GetAttributeValue<EntityReference>("owningteam").Id);
             Assert.Null(acc_Fresh.GetAttributeValue<EntityReference>("owninguser"));
         }
@@ -53,15 +40,15 @@ public void When_Assigned_User_As_Owner_OwningUser_Is_Set()
             var team1 = new Team { Id = Guid.NewGuid(), Name = "Team1" };
             var account1 = new Account { Id = Guid.NewGuid(), Name = "Acc1" };
 
-            _context.Initialize(new List<Entity> {
+            base._context.Initialize(new List<Entity> {
                 user1, team1, account1
             });
 
             var executor = new AssignRequestExecutor();
             AssignRequest req = new AssignRequest() { Target = account1.ToEntityReference(), Assignee = user1.ToEntityReference() };
             executor.Execute(req, _context);
 
-            var acc_Fresh = _context.GetOrganizationService().Retrieve(account1.LogicalName, account1.Id, new Microsoft.Xrm.Sdk.Query.ColumnSet(true));
+            var acc_Fresh = base._context.GetOrganizationService().Retrieve(account1.LogicalName, account1.Id, new Microsoft.Xrm.Sdk.Query.ColumnSet(true));
             Assert.Equal(user1.Id, acc_Fresh.GetAttributeValue<EntityReference>("owninguser").Id);
             Assert.Null(acc_Fresh.GetAttributeValue<EntityReference>("owningteam"));
         }
@@ -92,4 +79,4 @@ public void When_execute_is_called_with_a_null_assignee_exception_is_thrown()
             Assert.Throws<FaultException<OrganizationServiceFault>>(() => executor.Execute(req, _context));
         }
     }
-}
+}