-
Notifications
You must be signed in to change notification settings - Fork 61
Update PQC Draft to Version 12 #2355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
... for rnp_generate_key_ex add roundtrip test for PQC certs clang-format
require Botan 3.6.0 for PQC switch to final NIST PQC standards update KMAC Key Combiner
fail gracefully on parsing v6 cleartext sigs
also code formatting
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2355 +/- ##
=======================================
Coverage 85.46% 85.46%
=======================================
Files 126 126
Lines 22713 22731 +18
=======================================
+ Hits 19411 19427 +16
- Misses 3302 3304 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@ni4 3 checks fail due to the Botan version (3.6.0 required now). I suppose the images can easily be changed (or alternatively RFC95080/PQC disabled) in the corresponding yml files. I'm not familiar with your CI/CD setup, therefore I think someone else should do the necessary changes. |
This PR updates to the newest PQC draft version, and adds/fixes some RFC 9580 functionality. The PR replaces #2287. The PQC draft can be seen as stable now since it has passed Working Group Last Call recently.
The most prominent changes are:
V6 / RFC 9580
PQC
Further Code Changes
ENABLE_CRYPTO_REFRESH
is required forENABLE_PQC
ENABLE_CRYPTO_REFRESH
andENABLE_PQC
now requires Botan 3.6.CRYPTO_REFRESH_ENABLED
is true.@ni4 since I had to rebase a lot and fixed some stuff only at the end of the rebasing, the history is not perfectly intact. Please tell me if you prefer to keep the commits anyway or whether I should squash them into a single commit. I hope I did not mess anything up when rebasing.
As next steps I would like to rebase the other PRs #2296 and #2207 (that is considerably less code than in this PR).