Fix scheduled API security workflow - #1
Draft
rksharma-owg wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm ciin the active and reusable workflowsRoot cause
The scheduled workflow enabled npm caching without a dependency lockfile, so
actions/setup-nodefailed before dependency installation. The next step also targeted the reservedapi.example.testplaceholder, which could never provide a runnable scheduled test.The workflow now runs its smoke collection against the repository's disposable localhost lab, so scheduled and pull-request executions are self-contained and do not target an external API.
Validation
npm cinpm ci --prefix vulnerable-api-lab/node-apinpm run validate:payloadsgit diff --check