Skip to content

fix: [FEATURE] Add keyboard shortcut for jump-to-search #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bigdeen02 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: [FEATURE] Add keyboard shortcut for jump-to-search #1134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions frontend/src/App.keyboard-a11y.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,3 +137,31 @@ describe("bounty card keyboard navigation", () => {
expect(await axe(container)).toHaveNoViolations();
});
});

describe("jump-to-search keyboard shortcut", () => {
it("focuses the search input when / is pressed outside a text field", async () => {
const user = userEvent.setup();
await renderBoard();

const searchInput = screen.getByPlaceholderText("Search by repo, title, or label...");
expect(searchInput).not.toHaveFocus();

await user.keyboard("/");

expect(searchInput).toHaveFocus();
});

it("does not trigger the shortcut while typing inside a text input", async () => {
const user = userEvent.setup();
await renderBoard();

const searchInput = screen.getByPlaceholderText("Search by repo, title, or label...");
searchInput.focus();

await user.keyboard("/");

// The "/" should be typed into the input, not re-trigger the shortcut.
expect(searchInput).toHaveValue("/");
expect(searchInput).toHaveFocus();
});
});
Loading