React random colors #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hueter
suggested changes
Jan 3, 2018
There was a problem hiding this comment.
Hi @vikisimovska I'd like you to refactor this a bit to do away with the Boxes component and generate the array from 1 to 24 more programmatically.
| super(props); | ||
|
|
||
| this.state = { | ||
| numbers : [1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24] |
There was a problem hiding this comment.
😩
Array(24).fill(0).map((e, i) => i + 1);😄
| this.setState({ | ||
| numbers : newArr | ||
| }) | ||
| }, 300); |
There was a problem hiding this comment.
what is 300 supposed to do here?
| @@ -0,0 +1,12 @@ | |||
| import React, { Component } from 'react'; | |||
|
|
|||
| class Box extends Component{ | |||
There was a problem hiding this comment.
since there's no state it is preferable to use a stateless functional component
| import React, { Component } from 'react'; | ||
| import Box from './box'; | ||
|
|
||
| class Boxes extends Component{ |
There was a problem hiding this comment.
having this Boxes component is a bit of an anti-pattern. You don't really need a component whose only purpose is to render x number of a different component.
|
|
||
| render(){ | ||
| const boxList = this.props.numbers.map((num, idx) => { | ||
| return( |
There was a problem hiding this comment.
I would move this logic into <App />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding solution for Random Colors.