Skip to content

Conversation

@xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

See #23490 about the flag. The build.rustdocflags set in .cargo/config.toml is not effective when RUSTDOCFLAGS is already set.

Failures:
https://github.com/risingwavelabs/risingwave/actions/workflows/doc.yml

Fix verified:
https://github.com/risingwavelabs/risingwave/actions/runs/18774446293/job/53565733284

TODO:
Can we avoid the repetition?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@xiangjinwu xiangjinwu requested a review from wenym1 October 24, 2025 08:56
@github-actions github-actions bot added the A-ci Area: CI workflow and scripts, etc. label Oct 24, 2025
@xiangjinwu xiangjinwu added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit 1f7214b Oct 24, 2025
34 of 37 checks passed
@xiangjinwu xiangjinwu deleted the ci-doc-lifetime branch October 24, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: CI workflow and scripts, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants