Skip to content

feat(storage): define vector index metadata #21885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented May 15, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In this PR, we define the vector index metadata in hummock. The vector index will have a separate map field in HummockVersion, keyed by the table_id of the vector index. We also define the VectorIndexDelta in HummockVersionDelta to represent the changes to apply on the vector index. VectorIndexDelta can be either Init or Adds. Init consists of the initial config of the vector index, while Adds consists of the data later added by the vector index writer.

The GC and time travel logic is also updated, so that the vector index files can be tracked and properly GCed, and we can reuse the time travel mechanism of LSM for vector index.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Contributor Author

wenym1 commented May 15, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@wenym1 wenym1 marked this pull request as ready for review May 15, 2025 09:37
@wenym1 wenym1 force-pushed the yiming/hummock-vector-index-meta branch 2 times, most recently from b81e93d to 5e91d67 Compare May 22, 2025 06:36
@wenym1 wenym1 force-pushed the yiming/hummock-vector-index-meta branch from 5e91d67 to 74ed6d1 Compare May 22, 2025 07:16
@wenym1 wenym1 requested review from hzxa21, Li0k, xiangjinwu and zwang28 May 22, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant