feat: add ENV to control Kafka sdk log level #21865
Merged
+42
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new function `read_kafka_log_level` to read the log level from the environment variable `RISINGWAVE_KAFKA_LOG_LEVEL`. - Updated `KafkaConnection`, `KafkaSinkWriter`, and `KafkaSplitReader` to utilize the dynamic log level configuration. - Ensured that an invalid log level falls back to the default level of INFO with a warning log.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces dynamic control of the Kafka SDK log level via the new environment variable RISINGWAVE_KAFKA_LOG_LEVEL.
- Introduces the function read_kafka_log_level to read and parse the log level from the environment.
- Updates multiple Kafka-related modules (consumer, sink writer, and enumerator) to use the dynamic log level configuration.
- Adjusts module exports to incorporate the new log level reader for better configurability.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/connector/src/source/kafka/source/reader.rs | Updated consumer initialization to use dynamic log level. |
| src/connector/src/source/kafka/enumerator.rs | Configured enumerator with dynamic log level. |
| src/connector/src/sink/kafka.rs | Updated sink writer to set dynamic log level. |
| src/connector/src/connector_common/mod.rs | Added export for the read_kafka_log_level function. |
| src/connector/src/connector_common/connection.rs | New function read_kafka_log_level reading environment variable and falling back to INFO. |
Comments suppressed due to low confidence (1)
src/connector/src/connector_common/connection.rs:116
- The PR description specifies that an invalid log level should fall back to INFO with a warning log; consider using 'tracing::warn!' here instead of 'tracing::info!' to accurately reflect the intended log severity.
tracing::info!("Invalid RISINGWAVE_KAFKA_LOG_LEVEL: {}, using INFO instead", log_level);
xxchan
reviewed
May 14, 2025
src/connector/src/sink/kafka.rs
Outdated
| @@ -477,7 +477,9 @@ impl KafkaSinkWriter { | |||
| .await?; | |||
| let producer_ctx = RwProducerContext::new(ctx_common); | |||
| // Generate the producer | |||
| c.create_with_context(producer_ctx).await? | |||
| c.set_log_level(read_kafka_log_level()) | |||
There was a problem hiding this comment.
I think we can set sth like RUST_LOG="librdkafka=trace", why need a separate env var? 👀
xxchan
reviewed
May 14, 2025
- Modified `read_kafka_log_level` to return an `Option<RDKafkaLogLevel>` instead of a direct value. - Updated all instances in `KafkaConnection`, `KafkaSinkWriter`, `KafkaSplitReader`, and `KafkaSplitEnumerator` to handle the new return type, ensuring log level is set only if valid. - Improved error handling by returning `None` for invalid log levels instead of defaulting to INFO.
xxhZs
pushed a commit
that referenced
this pull request
May 29, 2025
Co-authored-by: tab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_kafka_log_levelto read the log level from the environment variableRISINGWAVE_KAFKA_LOG_LEVEL.KafkaConnection,KafkaSinkWriter, andKafkaSplitReaderto utilize the dynamic log level configuration.I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
proposed by @arkbriar
introduce
RISINGWAVE_KAFKA_LOG_LEVELto control the log level of kafka sdkaccept
What's changed and what's your intention?
Checklist
Documentation
Release note