fix(cdc): pass ownership of source message sender to java thread #20353
+104
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
commented
Jan 31, 2025
| @@ -389,7 +399,7 @@ extern "system" fn Java_com_risingwave_java_binding_Binding_iteratorClose<'a>( | |||
| _env: EnvParam<'a>, | |||
| pointer: OwnedPointer<JavaBindingIterator<'a>>, | |||
| ) { | |||
| pointer.drop() | |||
| pointer.release() | |||
There was a problem hiding this comment.
Renamed to avoid confusion with Drop trait or std::mem::drop function.
| @@ -152,21 +152,31 @@ impl<T> From<T> for Pointer<'static, T> { | |||
|
|
|||
| impl<'a, T> Pointer<'a, T> { | |||
| fn as_ref(&self) -> &'a T { | |||
| debug_assert!(self.pointer != 0); | |||
| assert!(self.pointer != 0); | |||
There was a problem hiding this comment.
Doesn't seem to be a heavy operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Pass the ownership of Debezium CDC source message sender to the Java thread by creating a wrapper of it. Use
Cleanerin the Java code to release memory when it's no longer needed.Previously there was memory unsafety: #19783.
Checklist
Documentation
Release note