Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add privilege check for drop user #20199

Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix: add privilege check for drop user #20199

merged 1 commit into from
Jan 17, 2025
+38 −7

Conversation

yezizp2012
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

To maintain consistency with pg's behavior: https://www.postgresql.org/docs/current/sql-droprole.html

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@yezizp2012 yezizp2012 enabled auto-merge January 17, 2025 08:56
@github-actions github-actions bot added the type/fix Bug fix label Jan 17, 2025
@yezizp2012 yezizp2012 added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 2d31661 Jan 17, 2025
29 of 30 checks passed
@yezizp2012 yezizp2012 deleted the fix/drop-user-check branch January 17, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanicky shanicky shanicky approved these changes

@st1page st1page Awaiting requested review from st1page

Assignees
No one assigned
Labels
type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yezizp2012 @shanicky