feat: drop connector for table with connector #20023
Open
+642
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 4, 2025 16:04
|
replacement for #19871 |
tabVersion
commented
Jan 8, 2025
added 7 commits
January 12, 2025 19:54
tabVersion
requested review from
yezizp2012,
shanicky,
fuyufjh,
xiangjinwu and
BugenZhao
fuyufjh
reviewed
Jan 17, 2025
| {"ID": 8}^{"ID": 8, "firstName": "Ava", "lastName": "Garcia", "age": 21, "height": 5.2, "weight": 115} | ||
| EOF | ||
|
|
||
| # the streaming job does not intake new data |
There was a problem hiding this comment.
Better to sleep a while before this check
| // additional column name may have prefix _rw | ||
| // When converting dropping the connector from table, the additional columns are converted to normal columns and keep the original name. | ||
| // Under this case, we loosen the check for _rw prefix. | ||
| if column_name.starts_with(RW_RESERVED_COLUMN_NAME_PREFIX) && !is_for_replace_plan { |
There was a problem hiding this comment.
I think there is no need to enter this function (check_valid_column_name()) at all when is_for_replace_plan == true.
For exaample, is_row_id_column_name may also need to be bypassed when you work on alter source alter connector
| WITH ( | ||
| ${RISEDEV_KAFKA_WITH_OPTIONS_COMMON}, | ||
| topic = 'test_alter_table_drop_connector') | ||
| FORMAT PLAIN ENCODE JSON; |
There was a problem hiding this comment.
Is this shared source? Can you also add a test case for some non-shared source?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
Documentation
Release note
new syntax for dropping connector part of a table
only allow for table with associate source, not works for plain table and CDC table.