Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an option to pass sensitive variable through CLI arg #15

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

wjf3121
Copy link
Contributor

@wjf3121 wjf3121 commented Dec 6, 2024

Currently, the only way to pass variables is to pass a .tfvars.json file for terraform to load. This face the risk that sensitive variables will be temporarily persisted on disk.

This PR adds the option to use command line args to pass these sensitive vars so that they won't be on disk at any given time.

Part of CLOUD-3489

@wjf3121 wjf3121 requested a review from lukeraphael December 6, 2024 18:00
@wjf3121 wjf3121 requested a review from a team as a code owner December 6, 2024 18:00
Copy link

linear bot commented Dec 9, 2024

Copy link

@lukeraphael lukeraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wjf3121 wjf3121 added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit bf88417 Dec 9, 2024
2 checks passed
@wjf3121 wjf3121 deleted the junfeng/variable-through-env branch December 9, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants