fix(bin): fix newline handling for --format/override
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
skyzh
approved these changes
Dec 10, 2022
xxchan
commented
Dec 10, 2022
| outfile: &mut File, | ||
| ) -> std::io::Result<()> { | ||
| // check whether outfile ends with multiple newlines, which happens if | ||
| // - the last record is statement/query |
There was a problem hiding this comment.
cc @alamb This is an egde case we need to consider after adding \n to Display of statement and query. 😇
We need to consider it if we want file to end with newline. i.e., like
for record in records {
println!("{record}");
}
In the roundtrip parsing test, it uses join
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#127 introduced
Record::Newline. We don't need to insert newlines between records, and we can preserve newlines.