-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme: Fix build instructions #1075
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems right at first glance. However, it's different than .github/workflows/verify.yml (which I'm not an expert on). Any thoughts on that? And while I'm looking in the .github directory, does .github/workflows/publish.yml need to be updated? It still has the texlive stuff in it.
4951a5d
to
9f5178c
Compare
The Readme contained the old (pre-adoc) build instructions. Fix them to describe the current build process. Mention also the use of submodules, which are needed for the documentation to build.
9f5178c
to
5dc62af
Compare
Hello @pdonahue-ventana - I have checked I have also looked at
I propose to remove it (in another merge request: #1078). |
@rtwfroody @pdonahue-ventana Could this PR be merged, please? Thank you. |
@pdonahue-ventana Gentle ping, could this PR be merged, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The Readme still contained old (pre-adoc) build instructions. Fix it.
Mention also the use of submodules which are needed for the documentation to build.