remove C prefix from capability mode load/store/atomics #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichardson
reviewed
Feb 2, 2024
arichardson
reviewed
Feb 2, 2024
There was a problem hiding this comment.
I'm not quite sure what the best style for the prerequisites section is, but the change itself looks good to me.
It seems there are some trailing spaces, you can fix those using pip install pre-commit && pre-commit install && pre-commit run --all-files to make CI happy.
Co-authored-by: Alexander Richardson <[email protected]> Signed-off-by: Tariq Kurd <[email protected]>
arichardson
reviewed
Feb 7, 2024
arichardson
requested changes
Feb 7, 2024
Signed-off-by: Alexander Richardson <[email protected]>
arichardson
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First phase of renaming for #80
Loads/stores/atomics
prefetch, CBO, jumps, shxadd to be done