-
Notifications
You must be signed in to change notification settings - Fork 76
fix: remove processing raw yaml files in exception cause generation #1189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: remove processing raw yaml files in exception cause generation #1189
Conversation
Hi @AliAlaa88! I see that you have multiple commits in this PR. I suppose you don't want to merge all of them together, and probably this is just an addition to your SVerilog branch, so what you can do is do a PR against that branch instead of against main, does this seem good? |
This doesn't depend on the SystemVerilog branch, so it might make more sense to still target the main branch and only include the last commit (which seems like the relevant one here). |
should i create a branch from the main and cherry-pick the relevant commit or what? |
@AliAlaa88 Yes, that's pretty much it. Then force-push into this remote branch so it shows up on the PR. |
…ion code generation
8c33bf0
to
80e2b1c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1189 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 11 11
Lines 4942 4942
Branches 1345 1345
=======================================
Hits 2276 2276
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AliAlaa88 I think your commit is not adding what you would like to add, right?
It is overriding the load_exception_codes function in the generator.py |
This PR related to PR #1090 which requests removal of processing raw yaml files in exception cause generation to prevent generation of wrong codes #1145