feat: add some Smctr CSRs #1172
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-apt-abdullah
requested review from
ThinkOpenly and
dhower-qc
as code owners
ThinkOpenly
requested changes
Oct 7, 2025
There was a problem hiding this comment.
Pretty good!
Could you add support for this from the spec?
All fields are optional except for M, S, U, and BPFRZ. All unimplemented fields are read-only 0, while all implemented fields are writable. If the Sscofpmf extension is implemented, LCOFIFRZ must be writable.
|
Do you expect to include the rest of the Smctr CSRs?
...or shall we punt that to a later PR? |
|
The CI tests are failing due to dependence on #554. (FYI) |
Yes, I’ll add that.
I’d prefer to refine these first and get them merged before moving on to the rest — maybe open another PR for the remaining ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #555