feat(IDL): single precision floating point division and multiplication #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recision-instruction-idl-code feat(idl): add softfloat_normSubnormalF32Sig function.
…recision-instruction-idl-code feat(idl): implement single precision fmul
…recision-instruction-idl-code data: add IDL operation for fmul
…recision-instruction-idl-code fix: typo in packToF32UI function call
…recision-instruction-idl-code fix: function call to roundPackToF32
feat(idl): single precision floating point division
dhower-qc
requested changes
Oct 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1160 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 11 11
Lines 4942 4942
Branches 1345 1345
=======================================
Hits 2276 2276
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShashankVM
changed the title
…truction' into fmul_branch
fix: mark_f_state_dirty in fmul and fdiv
|
@dhower-qc I can see some regression tests are failing now. I am not able to understand how the error printed relates to a bug in my code. Could you please clarify if it's a bug in my code or the Ruby code? |
dhower-qc
approved these changes
Oct 2, 2025
|
Closing this as all changes are in #1165 |
auto-merge was automatically disabled
October 4, 2025 18:40
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1158 and #1149